-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Styling issues and make RTD build work #968
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #968 +/- ##
==========================================
- Coverage 88.91% 88.88% -0.03%
==========================================
Files 27 27
Lines 3375 3375
Branches 618 618
==========================================
- Hits 3001 3000 -1
Misses 227 227
- Partials 147 148 +1
☔ View full report in Codecov by Sentry. |
Both this PR and #966 look good to me, but they are separately failing checks (RTD build for this one and style for the RTD fix). Can you combine these changes into a single PR so that all the checks pass before merging? Otherwise I'm fine approving both and merging separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. As I mentioned in a comment, I think it would be better to have one PR with this and #966 so that all checks pass, but I'll approve this in case we decide to merge separately.
I can merge this with the other PR tomorrow. But I don't mind if they get merged separately either. Edit: I will merge them together in the morning if they haven't been merged into main yet. |
This PR is quite simple and is mostly testing-related. I think 1 approval would be enough. Thoughts @handwerkerd? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This is fairly minor and holding up a bunch of other PRs. I'll give @tsalo @n-reddy @marco7877 and @dowdlelt a few hours to see if they object and want to check this more carefully. Otherwise, I'll merge with just my approving review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super simple, knock it out!
Closes #967, Closes #961
Changes proposed in this pull request:
type(a) is list
instead oftype(a) == list
.