Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it clearer in CONTRIBUTING.md how devs can make pre-commit work #985

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

eurunuela
Copy link
Collaborator

@eurunuela eurunuela commented Oct 18, 2023

Closes none.

Changes proposed in this pull request affect CONTRIBUTING.md:

  • Mentioned the installation of pre-commit and referenced the pre-commit docs.
  • Mentioned that pre-commit install must be run within the tedana repository to install the hooks that enforce the style guidelines are followed.

@eurunuela eurunuela changed the title Make it clearer how devs can make pre-commit work Make it clearer in CONTRIBUTING.md how devs can make pre-commit work Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3450103) 89.02% compared to head (5e031aa) 89.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #985   +/-   ##
=======================================
  Coverage   89.02%   89.02%           
=======================================
  Files          27       27           
  Lines        3417     3417           
  Branches      622      622           
=======================================
  Hits         3042     3042           
  Misses        227      227           
  Partials      148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@handwerkerd handwerkerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurunuela eurunuela requested a review from tsalo October 20, 2023 19:54
@handwerkerd
Copy link
Member

Just sure if @tsalo wants to take a look, but this is just documentation & I'm fine merging with just one approval.

@eurunuela eurunuela merged commit b11d254 into ME-ICA:main Oct 23, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants