Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing fcio functions to LLVM-MOS build #56

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

mlund
Copy link
Collaborator

@mlund mlund commented Jul 19, 2024

LLVM-MOS now has stdio support which enables the missing features in fcio on clang. Note that llvm-mos stdio is largely untested on the mega65 target and things might not work. This should eventually be fixed in llvm-mos-sdk, not in mega65-libc.

This fails on CI due to missing asm clobber fix which has not made it into master branch.

Checklist

Thanks a lot for your contribution!
Please tick off the following:

  • Tests run successfully (i.e. make test)
    • using the CC65 compiler
    • using the LLVM/Clang compiler
  • Doxygen style tags are used for public API
  • Source code is properly formatted; run e.g. clang-format -i <file>
  • I agree to the GNU Lesser General Public License of this repository

The commodore targets on llvm-mos has gained stdio
support which now enables the missing features in
fcio. Note though that the llvm-mos stdio is largely
untested on mega65 and things might not work. This
should eventually be fixed but in llvm-mos, not in
mega65-libc.
@mlund mlund added the enhancement New feature or request label Jul 19, 2024
@mlund mlund requested a review from steph72 July 19, 2024 07:52
@mlund mlund changed the base branch from master to development July 19, 2024 07:56
@mlund mlund requested review from gurcei and lydon42 July 19, 2024 07:57
@mlund mlund merged commit d306001 into MEGA65:development Jul 19, 2024
1 check passed
@mlund mlund deleted the fcio-file branch July 19, 2024 18:25
@mlund mlund mentioned this pull request Sep 8, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant