Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gdt 163 access type filters #803

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Gdt 163 access type filters #803

merged 4 commits into from
Mar 4, 2024

Conversation

JPrevost
Copy link
Member

@JPrevost JPrevost commented Mar 1, 2024

Why are these changes being introduced:

  • geo UI has a requirement to filter records by this aggregation
  • geo UI has a requirement to display the provider

Relevant ticket(s):

How does this address that need:

  • Adds OpenSearch aggregation using a filtered set of Rights
  • Adds GraphQL aggregation
  • Adds GraphQL search filter parameter
  • Adds provider to Record

Document any side effects to this change:

A few high maintenance tests had some values changed in their
assertions to match the changing data we are testing against.

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

YES | NO

Includes new or updated dependencies?

YES | NO

JPrevost added 3 commits March 1, 2024 13:59
Why are these changes being introduced:

* geo UI has a requirement to filter records by this aggregation

Relevant ticket(s):

* https://mitlibraries.atlassian.net/browse/GDT-163

How does this address that need:

* Adds OpenSearch aggregation using a filtered set of Rights
* Adds GraphQL aggregation
* Adds GraphQL search filter parameter

Document any side effects to this change:

A few high maintenance tests had some values changed in their
assertions to match the changing data we are testing against.
@JPrevost JPrevost temporarily deployed to timdex-pr-803 March 1, 2024 21:39 Inactive
@JPrevost
Copy link
Member Author

JPrevost commented Mar 1, 2024

This query may be helpful for seeing both the new field as well as how to apply the new filter:

{
  search(index: "geo", accessToFilesFilter: ["Free/open to all", "MIT authentication"]) {
    hits
    records {
      title
      source
      provider
    }
    aggregations {
      accessToFiles {
        docCount
        key
      }
    }
  }
}

@jazairi jazairi self-assigned this Mar 4, 2024
Copy link
Contributor

@jazairi jazairi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always nice to get a two-for-one like this. :)

@JPrevost JPrevost merged commit 0b13697 into main Mar 4, 2024
4 checks passed
@JPrevost JPrevost deleted the gdt-163-access-type-filters branch March 4, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants