Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated transformer tool into CLI #4

Merged
merged 8 commits into from
Aug 10, 2020
Merged

Conversation

jessieAnhNguyen
Copy link
Member

@jessieAnhNguyen jessieAnhNguyen commented Jul 30, 2020

Summary:


  • Solves Add flags to the download Hermes command #3

  • Add the -verbose flag to list out internal adb commands (help to debug)

  • Integrate the transformer tool written by @saphal1998, which are included in the files:

    • ./commands/profile/cpuProfilerModel
    • ./commands/profile/EventInterfaces
    • ./commands/profile/Phases
    • ./commands/profile/SourceMapper
    • ./commands/profile/transformer
  • Add the --raw flag, in which case will download the original Hermes profile. Default, the program will convert the file to Chrome json format, then download it.

  • Note: this PR is the collaborative work between @saphal1998 and I

Test Plan:


  • I first followed this guide on how to test changes Testing changes

  • After that, the usage of the command is:

    • profile-hermes [destinationDir]: destinationDir is optional, provide the directory where users want to pull the file to (if not present, pull to the current React Native root directory)
    • Options:
      • --fileName [string]: specify which profile users want to pull (if not present, pull the latest profile)

      • --verbose: list out internal adb commands that are run (help to debug)

      • --raw: download the original Hermes formatted profile (if not present, convert to Chrome json format)
        Example:
        Example of using --raw and --verbose

      • --sourceMapPath [string]: provide the local path to your source map file
        Example:
        Example of using --sourceMapPath

  • Make sure your emulator is running and adb is connected

@jessieAnhNguyen jessieAnhNguyen self-assigned this Jul 30, 2020
@jessieAnhNguyen jessieAnhNguyen linked an issue Jul 30, 2020 that may be closed by this pull request
2 tasks
Copy link
Member

@saphal1998 saphal1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but a couple of things can be removed.

packages/cli/src/commands/profile/EventInterfaces.ts Outdated Show resolved Hide resolved
packages/cli/src/commands/profile/index.ts Outdated Show resolved Hide resolved
@jessieAnhNguyen jessieAnhNguyen merged commit 86c8110 into master Aug 10, 2020
@jessieAnhNguyen jessieAnhNguyen deleted the test/transformer branch August 10, 2020 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flags to the download Hermes command
2 participants