Integrated transformer tool into CLI #4
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Solves Add flags to the download Hermes command #3
Add the
-verbose
flag to list out internal adb commands (help to debug)Integrate the transformer tool written by @saphal1998, which are included in the files:
./commands/profile/cpuProfilerModel
./commands/profile/EventInterfaces
./commands/profile/Phases
./commands/profile/SourceMapper
./commands/profile/transformer
Add the --raw flag, in which case will download the original Hermes profile. Default, the program will convert the file to Chrome json format, then download it.
Note: this PR is the collaborative work between @saphal1998 and I
Test Plan:
I first followed this guide on how to test changes Testing changes
After that, the usage of the command is:
profile-hermes [destinationDir]
:destinationDir
is optional, provide the directory where users want to pull the file to (if not present, pull to the current React Native root directory)--fileName [string]
: specify which profile users want to pull (if not present, pull the latest profile)--verbose
: list out internal adb commands that are run (help to debug)--raw
: download the original Hermes formatted profile (if not present, convert to Chrome json format)Example:
--sourceMapPath [string]
: provide the local path to your source map fileExample:
Make sure your emulator is running and adb is connected