Apply RuboCop auto-corrections for code style improvements

MLH · Nov 11, 2024 · aefa98f · aefa98f
1 parent 2ef82c8
commit aefa98f
Show file tree

Hide file tree

Showing 4 changed files with 45 additions and 39 deletions.
diff --git a/lib/omniauth/strategies/mlh.rb b/lib/omniauth/strategies/mlh.rb
@@ -33,7 +33,7 @@ class MLH < OmniAuth::Strategies::OAuth2 # :nodoc:
         site: 'https://my.mlh.io',
         authorize_url: 'oauth/authorize',
         token_url: 'oauth/token',
-        auth_scheme: :request_body  # Change from basic auth to request body
+        auth_scheme: :request_body # Change from basic auth to request body
       }
 
       # Support expandable fields through options
@@ -43,32 +43,32 @@ class MLH < OmniAuth::Strategies::OAuth2 # :nodoc:
 
       info do
         prune_hash({
-          # Basic fields
-          id: data[:id],
-          created_at: data[:created_at],
-          updated_at: data[:updated_at],
-          first_name: data[:first_name],
-          last_name: data[:last_name],
-          email: data[:email],
-          phone_number: data[:phone_number],
-          roles: data[:roles],
+                     # Basic fields
+                     id: data[:id],
+                     created_at: data[:created_at],
+                     updated_at: data[:updated_at],
+                     first_name: data[:first_name],
+                     last_name: data[:last_name],
+                     email: data[:email],
+                     phone_number: data[:phone_number],
+                     roles: data[:roles],
 
-          # Expandable fields
-          profile: data[:profile],
-          address: data[:address],
-          social_profiles: data[:social_profiles],
-          professional_experience: data[:professional_experience],
-          education: data[:education],
-          identifiers: data[:identifiers]
-        })
+                     # Expandable fields
+                     profile: data[:profile],
+                     address: data[:address],
+                     social_profiles: data[:social_profiles],
+                     professional_experience: data[:professional_experience],
+                     education: data[:education],
+                     identifiers: data[:identifiers]
+                   })
       end
 
       def data
         @data ||= begin
           # Support expandable fields through options
           expand_fields = options[:expand_fields] || []
           expand_query = expand_fields.map { |f| "expand[]=#{f}" }.join('&')
-          url = "https://api.mlh.com/v4/users/me"
+          url = 'https://api.mlh.com/v4/users/me'
           url += "?#{expand_query}" unless expand_fields.empty?
 
           response = access_token.get(url).parsed
@@ -89,15 +89,15 @@ def prune_hash(hash)
       end
 
       def symbolize_nested_arrays(hash)
-        hash.each_with_object({}) do |(key, value), result|
-          result[key] = case value
-                       when Hash
-                         symbolize_nested_arrays(value)
-                       when Array
-                         value.map { |item| item.is_a?(Hash) ? symbolize_nested_arrays(item) : item }
-                       else
-                         value
-                       end
+        hash.transform_values do |value|
+          case value
+          when Hash
+            symbolize_nested_arrays(value)
+          when Array
+            value.map { |item| item.is_a?(Hash) ? symbolize_nested_arrays(item) : item }
+          else
+            value
+          end
         end
       end
     end

diff --git a/spec/omniauth_mlh_spec.rb b/spec/omniauth_mlh_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe OmniAuth::MLH do

diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 $LOAD_PATH.unshift File.expand_path('../lib', __dir__)
 require 'bundler/setup'
 require 'webmock/rspec'
@@ -18,7 +20,7 @@
 require 'omniauth_mlh'
 require 'omniauth/strategies/mlh'
 
-Dir[File.expand_path('support/**/*.rb', __dir__)].each { |f| require f }
+Dir[File.expand_path('support/**/*.rb', __dir__)].sort.each { |f| require f }
 
 RSpec.configure do |config|
   config.expect_with :rspec do |c|

diff --git a/spec/support/shared_examples.rb b/spec/support/shared_examples.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.shared_examples 'basic data retrieval tests' do
   context 'with successful API response' do
     before do
@@ -18,16 +20,16 @@
 RSpec.shared_examples 'expandable fields tests' do
   let(:expanded_user_data) do
     base_user_data.merge({
-      'profile' => {
-        'age' => 22,
-        'gender' => 'Female'
-      },
-      'education' => [{
-        'current' => true,
-        'school_name' => 'Hacker University',
-        'major' => 'Computer Science'
-      }]
-    })
+                           'profile' => {
+                             'age' => 22,
+                             'gender' => 'Female'
+                           },
+                           'education' => [{
+                             'current' => true,
+                             'school_name' => 'Hacker University',
+                             'major' => 'Computer Science'
+                           }]
+                         })
   end
 
   context 'with expandable fields' do