This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
Make work with Julia 1.5, except for chordal embeddings #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made these changes to make the code work with Julia 1.5, since I had difficulty installing older versions of Julia. They're not great, but I tested against the notebooks and made sure they worked and the results were the same or close enough.
This commit only contains changes in
src
. I also have the updates to the notebooks, but didn't want to commit them because (1) I never figured out how to makeusing Polyopt
work and so I usedinclude("Polyopt.jl")
instead (2) changes to notebooks can't be diffed.The exception is the chordal embeddings: I wasn't able to figure out how the old code with
cholfact()
worked and so couldn't update to the newcholesky()
interface. Also there's a warning about not being able to importBase.sub
, which I didn't know what that was supposed to do, so I wasn't able to fix that.Possibly you'll want to keep both versions of the code, in case someone is still using the Julia 0.6 build?