-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Antarctic 1000m isobath transect and region #202
base: main
Are you sure you want to change the base?
Conversation
@alicebarthel, this is the geojson transect I was suggesting you might want to use for studying water-mass transport. The next steps would be to use it to get a list of edges and distances along the transect. I will look into that next. |
@alicebarthel, okay, so it's more complicated than I was hoping. We have tools for:
I'm going to have to think about this. |
71eae86
to
ba4696b
Compare
width = 30e3 | ||
x0 = x[0] | ||
y0 = y[0] | ||
square = shapely.geometry.Polygon([(x0 - width, y0 - width), | ||
(x0 + width, y0 - width), | ||
(x0 + width, y0 + width), | ||
(x0 - width, y0 + width), | ||
(x0 - width, y0 - width)]) | ||
|
||
difference = transect.difference(square) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ba4696b
to
8dd2984
Compare
@alicebarthel and @cbegeman, as we decided I:
|
@xylar pointed me to this from the MPAS-quickviz PR and couldn't help taking a look :). |
@milenaveneziani, I agree that looks odd but this contour is straight from BedMachine v3 so I think it will be consistent with E3SM v3 meshes. We could make a Bedmap 2 version for v2 meshes but I'd prefer not to if it can be avoided. |
I understand. I worry that the region might come out 'interrupted', if you know what I mean. Maybe Alice could try to compute a regional mask for one of the v3 meshes and check that with paraview? |
@milenaveneziani, another thing to keep in mind is that the ice-shelves sometimes overhang the 1000m isobath in Dronning Maud Land. So in meshes with ice-shelf cavities, the coastline that you're seeing plotted is the calving front, not the grounding line and the transect should be unbroken. Working with the E3SM v2 SORRM mesh, the transect seems to be fine (it's continuous). I haven't tried the E3SM v3 Icos30 or the E3SM v2 EC30to60 meshes yet. |
yes, I have considered that. And it's good to know that that is the case for the v2 SORRM mesh. |
@alicebarthel, I would like to make a new geometric_features release with this feature added. Do you have time to review it today or tomorrow? |
These features will hopefully be useful for studying export of water masses.