Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Antarctic 1000m isobath transect and region #202

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented May 23, 2024

These features will hopefully be useful for studying export of water masses.

@xylar xylar requested a review from alicebarthel May 23, 2024 11:06
@xylar
Copy link
Collaborator Author

xylar commented May 23, 2024

@alicebarthel, this is the geojson transect I was suggesting you might want to use for studying water-mass transport. The next steps would be to use it to get a list of edges and distances along the transect. I will look into that next.

@xylar
Copy link
Collaborator Author

xylar commented May 23, 2024

@alicebarthel, okay, so it's more complicated than I was hoping. We have tools for:

I'm going to have to think about this.

@xylar xylar force-pushed the add-bedmachine-v3-1000m-transect branch from 71eae86 to ba4696b Compare May 24, 2024 12:11
Comment on lines 68 to 77
width = 30e3
x0 = x[0]
y0 = y[0]
square = shapely.geometry.Polygon([(x0 - width, y0 - width),
(x0 + width, y0 - width),
(x0 + width, y0 + width),
(x0 - width, y0 + width),
(x0 - width, y0 - width)])

difference = transect.difference(square)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up needing to cut a little square out of the transect. The mask creator (specifically the code that finds edge signs) was totally confused by the transect being a closed loop. We could make the square less than 60 km in size if we want to.

Here's what that gap ends up looking like:
edge_sign

@xylar xylar force-pushed the add-bedmachine-v3-1000m-transect branch from ba4696b to 8dd2984 Compare June 5, 2024 19:27
@xylar
Copy link
Collaborator Author

xylar commented Jun 5, 2024

@alicebarthel and @cbegeman, as we decided I:

  • added a second feature defining the region enclosed by the 1000m isobath
  • did not remove any part of the transect or region so that it is a closed contour

@xylar xylar changed the title Add Antarctic isobath at -1000.0 m Add Antarctic 1000m isobath transect and region Jun 5, 2024
@milenaveneziani
Copy link
Collaborator

@xylar pointed me to this from the MPAS-quickviz PR and couldn't help taking a look :).
I'm a bit concerned by the intersection of the 1000m isobath with the coastline between ~20W and ~20E:
Screen Shot 2024-06-05 at 4 22 38 PM
If I look at a plot of bed topography and grounding line, it seems like the 1000m isobath should follow a more offshore route in the eastern Weddell:
Antarctic-BEDMAP2-topography-Fretwell-et-al-2013-rebounded-after-the-removal-of

@xylar
Copy link
Collaborator Author

xylar commented Jun 5, 2024

@milenaveneziani, I agree that looks odd but this contour is straight from BedMachine v3 so I think it will be consistent with E3SM v3 meshes. We could make a Bedmap 2 version for v2 meshes but I'd prefer not to if it can be avoided.

@milenaveneziani
Copy link
Collaborator

I understand. I worry that the region might come out 'interrupted', if you know what I mean. Maybe Alice could try to compute a regional mask for one of the v3 meshes and check that with paraview?

@xylar
Copy link
Collaborator Author

xylar commented Jun 6, 2024

@milenaveneziani, another thing to keep in mind is that the ice-shelves sometimes overhang the 1000m isobath in Dronning Maud Land. So in meshes with ice-shelf cavities, the coastline that you're seeing plotted is the calving front, not the grounding line and the transect should be unbroken. Working with the E3SM v2 SORRM mesh, the transect seems to be fine (it's continuous). I haven't tried the E3SM v3 Icos30 or the E3SM v2 EC30to60 meshes yet.

@milenaveneziani
Copy link
Collaborator

the coastline that you're seeing plotted is the calving front

yes, I have considered that. And it's good to know that that is the case for the v2 SORRM mesh.

@xylar
Copy link
Collaborator Author

xylar commented Jul 18, 2024

@alicebarthel, I would like to make a new geometric_features release with this feature added. Do you have time to review it today or tomorrow?

@xylar xylar self-assigned this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants