Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSSify Sending #20

Merged
merged 3 commits into from
Aug 4, 2022
Merged

OSSify Sending #20

merged 3 commits into from
Aug 4, 2022

Conversation

kafonek
Copy link
Contributor

@kafonek kafonek commented Aug 3, 2022

Move all the standard Open Source Software (OSS) patterns we use in other Noteable repos into Sending. Along with these updates, had to make some tweaks to test syntax and pyproject.toml.

  • CI/CD tests are run in ci.yaml now
    • Installs and starts redis-server as part of the runner
  • Standardize syntax in noxfile / CI/CD files
  • Add feature/bug issue templates
  • Add publish-to-PyPI CI/CD action when tags are created
  • Add Contributing and Code of Conduct files
  • Add ipykernel as part of the Jupyter install (will close ipykernel deps #18)
  • Test runner installs all dependencies (it was failing during test gathering without those anyways)
  • Leave the minimal install options in place but remove pytest markers for redis and jupyter

@kafonek
Copy link
Contributor Author

kafonek commented Aug 3, 2022

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@kafonek kafonek marked this pull request as ready for review August 3, 2022 19:26
tizz98
tizz98 previously approved these changes Aug 3, 2022
@kafonek kafonek merged commit 2cd5b0e into main Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants