Add more hooks to support structlog contextvars #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
Codecov Report
@@ Coverage Diff @@
## main #36 +/- ##
==========================================
- Coverage 95.71% 94.89% -0.82%
==========================================
Files 8 8
Lines 467 490 +23
==========================================
+ Hits 447 465 +18
- Misses 20 25 +5
Continue to review full report at Codecov.
|
tizz98
approved these changes
Aug 25, 2022
There was a problem hiding this comment.
Generally looks good. I wonder if a future refactor could use something like event emitter pattern rather than defining hook functions (https://pypi.org/project/PyEventEmitter/)
kafonek
force-pushed
the
mrk/context_hook
branch
from
450e966
to
0fa318b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context_hookthat's called by inbound worker, outbound worker, and poll worker during their respectivewhile Trueloops. Intended to be used to setstructlog.contextvars.bind_contextvarsin application code. Can be defined as class methods or attached to an instance.Related PA issue https://github.com/noteable-io/planar-ally/pull/243