Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to TypeScript, fix #16 #17

Merged
merged 15 commits into from
Sep 6, 2023
Merged

Switch to TypeScript, fix #16 #17

merged 15 commits into from
Sep 6, 2023

Conversation

AFCMS
Copy link
Contributor

@AFCMS AFCMS commented Jul 3, 2023 •
edited
Loading

@LoneWolfHT

AFCMS added 6 commits June 29, 2023 23:34
@AFCMS
Replace .prettierrrc.json by .editorconfig (TypeScript + Markdown…
3c5f5de 
… standards + JetBrains specific)
@AFCMS
Mention in README the fact that environment variables can be placed i…
0985481 
…n a `.env` file
@AFCMS
Create node.yml
4323c32
@AFCMS
Mention NodeJS v16 in install instructions
a581946
@AFCMS
Initial TypeScript Port
6a1816e 
- Stop ignoring package-lock.json (nor recommended)
- Bump all dependencies
- Configure TypeScript Compiler
- Fix several unhandled potential errors
- Add many comments
- Migrate to TypeScript
@AFCMS
Add .vscode and .idea folders to gitignore
7c0206b
@LoneWolfHT
Copy link
Member

#1 can be ignored for now

@AFCMS
Copy link
Contributor Author

AFCMS commented Jul 4, 2023

I will perhaps do more refactoring to prepare codebase to #16 and #18

@AFCMS
Copy link
Contributor Author

AFCMS commented Aug 1, 2023

Discord.js update juste landed

I will try to finish thé PR in the next few days

@AFCMS
Copy link
Contributor Author

AFCMS commented Aug 2, 2023

I looked into the possibility of using the global name or the server nickname instead of the username for the /x staff command. IDK what characters Minetest support compared to what is allowed in Discord, so I didn't implement this feature.

Anyway I consider this PR as ready for review @LoneWolfHT

@AFCMS AFCMS marked this pull request as ready for review August 2, 2023 14:57
@LoneWolfHT
Copy link
Member

I looked into the possibility of using the global name or the server nickname instead of the username for the /x staff command. IDK what characters Minetest support compared to what is allowed in Discord, so I didn't implement this feature.

If you can strip out everything but a-zA-Z0-9_- from the names I think that'll be enough.

Anyway I consider this PR as ready for review @LoneWolfHT

It'll be a few more days before I can test. Thanks

@AFCMS
Copy link
Contributor Author

AFCMS commented Aug 26, 2023

Fixed a problem with the http server and used the nickname/globalname instead of the username when possible.

@LoneWolfHT LoneWolfHT merged commit 10c5684 into MT-CTF:master Sep 6, 2023
@AFCMS AFCMS deleted the typescript_upgrade branch September 7, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AFCMS @LoneWolfHT