Fait renvoyer array aux getters qui renvoient ?array (#1052)

MTES-MCT · Nov 4, 2024 · a5d191a · a5d191a
1 parent 81d6108
commit a5d191a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/src/Application/Regulation/Command/DuplicateRegulationCommandHandler.php b/src/Application/Regulation/Command/DuplicateRegulationCommandHandler.php
@@ -53,8 +53,8 @@ private function duplicateRegulationOrderRecord(
         $generalInfo->organization = $organization;
         $generalInfo->identifier = $identifier;
         $generalInfo->description = $originalRegulationOrder->getDescription();
-        $generalInfo->additionalVisas = $originalRegulationOrder->getAdditionalVisas() ?? [];
-        $generalInfo->additionalReasons = $originalRegulationOrder->getAdditionalReasons() ?? [];
+        $generalInfo->additionalVisas = $originalRegulationOrder->getAdditionalVisas();
+        $generalInfo->additionalReasons = $originalRegulationOrder->getAdditionalReasons();
         $generalInfo->visaModelUuid = $originalRegulationOrder->getVisaModel()?->getUuid();
 
         return $this->commandBus->handle($generalInfo);

diff --git a/src/Domain/Regulation/RegulationOrder.php b/src/Domain/Regulation/RegulationOrder.php
@@ -79,14 +79,14 @@ public function getVisaModel(): ?VisaModel
         return $this->visaModel;
     }
 
-    public function getAdditionalVisas(): ?array
+    public function getAdditionalVisas(): array
     {
-        return $this->additionalVisas;
+        return $this->additionalVisas ?? [];
     }
 
-    public function getAdditionalReasons(): ?array
+    public function getAdditionalReasons(): array
     {
-        return $this->additionalReasons;
+        return $this->additionalReasons ?? [];
     }
 
     public function update(

diff --git a/tests/Unit/Application/Regulation/Command/DuplicateRegulationCommandHandlerTest.php b/tests/Unit/Application/Regulation/Command/DuplicateRegulationCommandHandlerTest.php
@@ -283,7 +283,7 @@ public function testRegulationFullyDuplicated(): void
         $this->originalRegulationOrder
             ->expects(self::once())
             ->method('getAdditionalVisas')
-            ->willReturn(null);
+            ->willReturn([]);
         $this->originalRegulationOrder
             ->expects(self::once())
             ->method('getVisaModel')