Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(elements): prefix styled component props in Legend #1364

Merged

Conversation

ivangabriele
Copy link
Member

@ivangabriele ivangabriele commented Sep 12, 2024

BREAKING CHANGE:

  • disabled is renamed $isDisabled in Legend props.
  • hasError is renamed $hasError in Legend props.
  • isHidden is renamed $isHidden in Legend props.

Related Pull Requests & Issues

Preview URL

https://637e01cf5934a2ae881ccc9d-yafgcjirlr.chromatic.com/

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.49%. Comparing base (46d1134) to head (f68458f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1364   +/-   ##
=======================================
  Coverage   57.49%   57.49%           
=======================================
  Files          55       55           
  Lines         807      807           
  Branches      274      274           
=======================================
  Hits          464      464           
  Misses        327      327           
  Partials       16       16           
Flag Coverage Δ
unit 57.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

BREAKING CHANGE:
- `disabled` is renamed `$isDisabled` in `Legend` props.
- `hasError` is renamed `$hasError` in `Legend` props.
- `isHidden` is renamed `$isHidden` in `Legend` props.
@ivangabriele ivangabriele force-pushed the ivan/fix-elements-prefix-styled-component-props-in-Legend branch from decbd35 to f68458f Compare September 12, 2024 13:07
@ivangabriele ivangabriele merged commit 3572267 into main Sep 12, 2024
22 checks passed
@ivangabriele ivangabriele deleted the ivan/fix-elements-prefix-styled-component-props-in-Legend branch September 12, 2024 13:23
@ivangabriele
Copy link
Member Author

🎉 This PR is included in version 23.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant