Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(components): simplify stylesheets injection in NewWindow #1384

Conversation

ivangabriele
Copy link
Member

@ivangabriele ivangabriele commented Sep 26, 2024

Related Pull Requests & Issues

None

Preview URL

https://637e01cf5934a2ae881ccc9d-cdlcforbax.chromatic.com/

@ivangabriele ivangabriele changed the title fix(components): handle external stylesheets cssRules CORS issue in N… fix(components): handle external stylesheets cssRules CORS issue in NewWindow Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.49%. Comparing base (f50288a) to head (04119ff).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1384   +/-   ##
=======================================
  Coverage   57.49%   57.49%           
=======================================
  Files          55       55           
  Lines         807      807           
  Branches      274      274           
=======================================
  Hits          464      464           
  Misses        327      327           
  Partials       16       16           
Flag Coverage Δ
unit 57.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ivangabriele ivangabriele force-pushed the ivan/fix-components-handle-external-stylesheets-cssRules-cors-issue-in-NewWindow branch from 33079c4 to 8500012 Compare September 26, 2024 06:57
@ivangabriele ivangabriele changed the title fix(components): handle external stylesheets cssRules CORS issue in NewWindow refactor(components): simplify stylesheets injection in NewWindow Sep 26, 2024
@ivangabriele ivangabriele force-pushed the ivan/fix-components-handle-external-stylesheets-cssRules-cors-issue-in-NewWindow branch from 8500012 to 1244187 Compare September 26, 2024 06:59
Copy link
Collaborator

@louptheron louptheron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ivangabriele ivangabriele force-pushed the ivan/fix-components-handle-external-stylesheets-cssRules-cors-issue-in-NewWindow branch from 1244187 to 04119ff Compare September 26, 2024 13:04
@ivangabriele ivangabriele merged commit 9ca5417 into main Sep 26, 2024
21 checks passed
@ivangabriele ivangabriele deleted the ivan/fix-components-handle-external-stylesheets-cssRules-cors-issue-in-NewWindow branch September 26, 2024 13:07
@ivangabriele
Copy link
Member Author

🎉 This PR is included in version 23.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants