Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Missions] Ajout du nom de l'infraction #2570

Merged
merged 2 commits into from
Oct 5, 2023
Merged

[Missions] Ajout du nom de l'infraction #2570

merged 2 commits into from
Oct 5, 2023

Conversation

louptheron
Copy link
Collaborator

ivangabriele
ivangabriele approved these changes Oct 4, 2023 •
edited
Loading
View reviewed changes
...features/SideWindow/MissionForm/ActionForm/shared/FormikMultiInfractionPicker/Infraction.tsx Outdated
@@ -7,7 +7,7 @@ import { MissionAction } from '../../../../../../domain/types/missionAction'
import type { Promisable } from 'type-fest'

export type InfractionProps<AnyInfraction extends MissionAction.OtherInfraction> = {
data: AnyInfraction
data: AnyInfraction & { infractionLabel: string | undefined }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On peut peut-être modifier AnyInfraction avec un prop optionnelle label?: string | undefined pour le coup ("infractionLabel").

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne sais pas s'il faut surcharger le type de base avec une prop seulement utilisée dans un composant.. Par contre bien vu pour seulement label.
wdyt ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ^^

@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@louptheron louptheron merged commit 99a2d1c into master Oct 5, 2023
25 checks passed
@louptheron louptheron deleted the loup/show-natinf-details branch October 5, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivangabriele ivangabriele ivangabriele approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NATINF – Rajouter un title sur tous les tags NATINF pour afficher leur libellé au survol
2 participants
@louptheron @ivangabriele