[DO NOT MERGE] [Missions] Add RapportNav as MissionSource #2574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louptheron
reviewed
Oct 10, 2023
There was a problem hiding this comment.
Merci, LGTM côté frontend!
Il manque juste la partie backend (car nous faisons proxy pour récupérer les missions depuis le backend Fish) :
Et ça serait bien de rajouter dans frontend/cypress/mappings/get-missions.json une mission comme source RAPPORTNAV, pour s'assurer que la chaîne fonctionne bien en test E2E.
|
Kudos, SonarCloud Quality Gate passed!
|
louptheron
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RapportNav va devoir créer des missions, il font donc que la source soit correctement reportée.
Dîtes moi si j'ai oublié quelque chose, merci.