Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Missions] Ajout des champs "Autres contrôles" #2623

Merged
merged 4 commits into from
Oct 19, 2023
Merged

[Missions] Ajout des champs "Autres contrôles" #2623

merged 4 commits into from
Oct 19, 2023

Conversation

louptheron
Copy link
Collaborator

ivangabriele
ivangabriele approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@ivangabriele ivangabriele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ca me va bien ^^. J'ai juste un doute aussi sur le naming otherControls que je trouve très générique, je me demande si on ne pourrait pas trouver un nom plus descriptif et métier ?

frontend/src/domain/shared_slices/Mission.ts Outdated
@@ -54,6 +55,7 @@ const INITIAL_STATE: MissionState = {
[MissionFilterType.STATUS]: [Mission.MissionStatus.IN_PROGRESS]
},
listSeaFront: SeaFrontGroup.MED,
resetOtherControls: undefined,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mustResetOtherControls ou willResetOtherControls ?

@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@louptheron louptheron merged commit 043b710 into master Oct 19, 2023
25 checks passed
@louptheron louptheron deleted the loup/add-other-control-checks branch October 19, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivangabriele ivangabriele ivangabriele approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mission - Pouvoir cocher les autres types de contrôle effectués lors d'un contrôle
2 participants
@louptheron @ivangabriele