Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cartographie] Réduire la transparence des couches REG #2693

Merged
merged 2 commits into from
Nov 8, 2023
Merged

[Cartographie] Réduire la transparence des couches REG #2693

merged 2 commits into from
Nov 8, 2023

Conversation

louptheron
Copy link
Collaborator

Linked issues

  • Tests E2E (Cypress)

ivangabriele
ivangabriele approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@ivangabriele ivangabriele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je remplacerais les getLayers() par un instanciation dès le premier render dans une réf, ce qui élimine pas mal d'évaluations à la volée. Mais peut-être que tu préfères refacto ça quand tu passeras les layers en vanilla JS ?

frontend/src/features/map/layers/RegulatoryLayers.tsx Outdated
regulatoryLayers.forEach(layer => {
// @ts-ignore
const vectorSource = layer.getSource()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est sensé passer en TS ça non (parce que ça passe sur Env) ? Pour le coup je trouve plus propre d'en faire un util comme j'ai fait sur Env car c'est récurrent.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui, il faut juste caster en VectorLayer, car une BaseLayer ne contient pas de Source

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@louptheron louptheron merged commit db2129c into master Nov 8, 2023
25 checks passed
@louptheron louptheron deleted the loup/update-regulation-layer-opacity branch November 8, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivangabriele ivangabriele ivangabriele approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Carto – Paramétrer la transparence des couches
2 participants
@louptheron @ivangabriele