Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JPE - Ajout du message "Capture d'espèces protégées" (CPS) #2768

Merged
merged 17 commits into from
Feb 14, 2024
Merged

JPE - Ajout du message "Capture d'espèces protégées" (CPS) #2768

merged 17 commits into from
Feb 14, 2024

Conversation

VincentAntoine
Copy link
Collaborator

@VincentAntoine VincentAntoine commented Dec 14, 2023 •
edited by louptheron
Loading

Linked issues

  • Pipeline : mise à jour du parser ERS
  • Back et front : affichage des données de type log_type=CPS
  • Rajouter nom entier de l'engin dans le payload de réponse API

@louptheron louptheron force-pushed the vincent/parse_catches_of_protected_species branch from fa35333 to 4785195 Compare January 12, 2024 14:34
@louptheron louptheron force-pushed the vincent/parse_catches_of_protected_species branch from 4785195 to 82c87e1 Compare February 9, 2024 08:46
@louptheron louptheron changed the title Vincent/parse catches of protected species JPE - Ajout du message "Capture d'espèces protégées" (CPS) Feb 9, 2024
@louptheron louptheron force-pushed the vincent/parse_catches_of_protected_species branch from 35f1bfd to a1bd560 Compare February 12, 2024 09:49
@louptheron louptheron marked this pull request as ready for review February 13, 2024 09:29
ivangabriele
ivangabriele approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@ivangabriele ivangabriele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Petite note : je ne suis pas sûr de voir l'intérêt d'utiliser des Set si c'est pour les convertir en Array ensuite.

frontend/src/domain/use_cases/fleetSegment/deleteFleetSegment.ts Outdated Show resolved Hide resolved
frontend/src/features/Logbook/utils.ts Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 13, 2024

Quality Gate Passed Quality Gate passed

Issues
92 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@louptheron louptheron merged commit f6f8344 into master Feb 14, 2024
25 checks passed
@louptheron louptheron deleted the vincent/parse_catches_of_protected_species branch February 14, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louptheron louptheron louptheron left review comments

@ivangabriele ivangabriele ivangabriele approved these changes

Assignees

@louptheron louptheron

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@VincentAntoine @ivangabriele @louptheron