Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Missions] Affichage des dates de création et de mise-à-jour #2771

Merged
merged 8 commits into from
Dec 22, 2023

Conversation

louptheron
Copy link
Collaborator

Linked issues


  • Tests E2E (Cypress)

@louptheron louptheron force-pushed the loup/add-created-updated-dates-mission-form branch from 34d4f24 to f25b78f Compare December 21, 2023 08:53
@louptheron louptheron force-pushed the loup/add-created-updated-dates-mission-form branch from f25b78f to 85bfab1 Compare December 22, 2023 10:41
{!isMissionFormValid && <FooterError>Veuillez corriger les éléments en rouge</FooterError>}

<MissionInfos>
{mainFormValues?.createdAtUtc && <>Mission créée {timeago.format(mainFormValues.createdAtUtc, 'fr')}. </>}
Copy link
Collaborator

@claire2212 claire2212 Dec 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ici je ne comprends pas pourquoi tu utilises timeago, il ne faut juste afficher la date de création?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Et bien je suis d'accord avec toi, même si dans les écrans c'est du timeago.
Je vais modifier, j'en parlerais avec Adeline à son retour.

}
export function AutoSaveTag({ isAutoSaveEnabled }: AutoSaveTagProps) {
return (
<Wrapper isAutoSaveEnabled={isAutoSaveEnabled}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tu ne pouvais pas utiliser le composant Tagde monitor-ui? normalement j'ai modifié des trucs pour faire en sorte qu'il soit customizable pour la couleur de fond et du texte

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il est utilisé :

const Wrapper = styled(Tag)<{

Ah oui bien vu pour color et backgroundColor, je vais les rajouter

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oups, désolée j'ai lu trop vite dans ce cas

Copy link

sonarcloud bot commented Dec 22, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@louptheron louptheron merged commit 5e9dd30 into master Dec 22, 2023
24 checks passed
@louptheron louptheron deleted the loup/add-created-updated-dates-mission-form branch December 22, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missions - Enregistrement automatique
2 participants