-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Missions] Affichage des dates de création et de mise-à-jour #2771
[Missions] Affichage des dates de création et de mise-à-jour #2771
Conversation
34d4f24
to
f25b78f
Compare
f25b78f
to
85bfab1
Compare
{!isMissionFormValid && <FooterError>Veuillez corriger les éléments en rouge</FooterError>} | ||
|
||
<MissionInfos> | ||
{mainFormValues?.createdAtUtc && <>Mission créée {timeago.format(mainFormValues.createdAtUtc, 'fr')}. </>} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ici je ne comprends pas pourquoi tu utilises timeago, il ne faut juste afficher la date de création?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Et bien je suis d'accord avec toi, même si dans les écrans c'est du timeago.
Je vais modifier, j'en parlerais avec Adeline à son retour.
} | ||
export function AutoSaveTag({ isAutoSaveEnabled }: AutoSaveTagProps) { | ||
return ( | ||
<Wrapper isAutoSaveEnabled={isAutoSaveEnabled}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tu ne pouvais pas utiliser le composant Tag
de monitor-ui? normalement j'ai modifié des trucs pour faire en sorte qu'il soit customizable pour la couleur de fond et du texte
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Il est utilisé :
const Wrapper = styled(Tag)<{
Ah oui bien vu pour color
et backgroundColor
, je vais les rajouter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oups, désolée j'ai lu trop vite dans ce cas
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 3 New issues |
Linked issues