[Unités] Pouvoir créer une mission à partir d'une unité #2815

ivangabriele · 2024-01-12T09:47:08Z

Unchecker les fichiers JSON (qui expliquent la taille de cette PR) pour la review.

Linked issues

Resolve Unités – Pouvoir créer une mission à partir d'une unité #2795
Resolve [Missions] Régression sur master lorsqu'on tente d'ouvrir une nouvelle mission alors qu'une autre mission est déjà ouverte en édition #2816
Resolve Missions - Impossible d'éditer une autre mission à partir de la carte lorsqu'une mission est déjà en cours d'édition #2837
Resolve Mission - L'ouverture d'une mission alors que le formulaire est déjà ouvert écrase les actions #2933

Tests E2E (Cypress)

frontend/src/features/SideWindow/MissionForm/index.tsx

frontend/src/features/VesselSidebar/Body.tsx

frontend/cypress/e2e/side_window/beacon_malfunction/board.spec.ts

frontend/src/domain/entities/sideWindow/types.ts

frontend/src/domain/use_cases/error/displayOrLogError.ts

frontend/src/domain/use_cases/error/retry.ts

frontend/src/features/SideWindow/MissionForm/shared/AutoSaveTag.tsx

louptheron · 2024-02-14T10:45:18Z

frontend/src/features/SideWindow/useCases/openSideWindowPath.ts

+export const openSideWindowPath =
+  (path: SideWindow.Path, withoutConfirmation: boolean = false): MainAppThunk =>
+  async (dispatch, getState) => {
+    const { missionForm, sideWindow } = getState()


Ce type de destruct est assez peu performant je crois, autant faire un getState().missionForm

Alors là contrairement au useSelector() c'est vraiment la même chose car le dispatcher n'est pas un hook qui subscribe. Ce n'est exécuté qu'une fois lorsqu'on l'appelle. La fonction getState() est exécutée et le store est renvoyé dans son ensemble quoique tu fasses. Même la déstrusturation en elle-même n'a un aucun impact de perf en elle-même dans ce cas car c'est un retour de fonction donc dans les deux cas 2 nouvelles valeurs en mémoire.

frontend/src/features/VesselSidebar/Body.tsx

frontend/src/libs/PendingUseCase.ts

frontend/src/features/SideWindow/useCases/askForSideWindowDraftCancellationConfirmation.ts

frontend/src/libs/PendingUseCase.ts

infra/docker/docker-compose.cypress.dev.yml

…rategy

louptheron

ça me parait bien avec l'utilisation de import-meta-env, on peut par contre préciser que les envs infra servent juste à faire tourner les images docker je pense. Je trouve qu'en l'état on ne sait pas quel env est lié à quoi, car on a de envs dans /fontend, dans /infra/configurations, dans /infra/.env.*

infra/.env.local.defaults

Makefile

infra/docker/app/env.sh

louptheron · 2024-02-21T09:26:17Z

infra/docker/docker-compose.monitorenv.dev.yml

+      timeout: 1s
+      retries: 30
+
+  monitorenv_flyway:


on peut enlever flyway - cf. le docker-compose puppeteer

A voir dans la PR de déplacement de /docker-compose.yml vers /infra/docker/docker-compose.yml.

sonarcloud · 2024-02-21T19:59:56Z

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

ivangabriele force-pushed the ivan/add-new-mission-button-in-control-unit-card branch 8 times, most recently from aff481b to a8a3edc Compare January 16, 2024 09:56

ivangabriele requested a review from louptheron January 16, 2024 13:00

ivangabriele marked this pull request as ready for review January 16, 2024 13:00

ivangabriele force-pushed the ivan/add-new-mission-button-in-control-unit-card branch from 78c6e36 to 63e7470 Compare January 16, 2024 15:49

louptheron reviewed Jan 23, 2024

View reviewed changes

frontend/src/features/SideWindow/MissionForm/index.tsx Outdated Show resolved Hide resolved

frontend/src/features/SideWindow/MissionForm/index.tsx Outdated Show resolved Hide resolved

frontend/src/features/SideWindow/MissionForm/index.tsx Outdated Show resolved Hide resolved

ivangabriele force-pushed the ivan/add-new-mission-button-in-control-unit-card branch from 5840731 to 70e480c Compare January 24, 2024 08:20

ivangabriele force-pushed the ivan/add-new-mission-button-in-control-unit-card branch 3 times, most recently from cb52072 to 6d2fb3f Compare February 9, 2024 07:49

ivangabriele added the feat. enhancement feature enhancement label Feb 10, 2024

ivangabriele force-pushed the ivan/add-new-mission-button-in-control-unit-card branch from ef344e2 to 43dac9a Compare February 12, 2024 16:56

louptheron reviewed Feb 12, 2024

View reviewed changes

frontend/src/features/VesselSidebar/Body.tsx Outdated Show resolved Hide resolved

ivangabriele requested a review from louptheron February 13, 2024 00:50

ivangabriele force-pushed the ivan/add-new-mission-button-in-control-unit-card branch from 4a614d3 to 6ed294f Compare February 13, 2024 00:54

louptheron reviewed Feb 14, 2024

View reviewed changes

louptheron mentioned this pull request Feb 14, 2024

Mission - L'ouverture d'une mission alors que le formulaire est déjà ouvert écrase les actions #2933

Closed

1 task

louptheron reviewed Feb 15, 2024

View reviewed changes

frontend/src/libs/PendingUseCase.ts Outdated Show resolved Hide resolved

ivangabriele force-pushed the ivan/add-new-mission-button-in-control-unit-card branch 3 times, most recently from 310326d to 2898d62 Compare February 15, 2024 23:40

ivangabriele added 2 commits February 20, 2024 16:59

Start gathering docker files in /infra/docker

b3cd13b

Fix SonarLint issues

af674eb

louptheron reviewed Feb 20, 2024

View reviewed changes

infra/docker/docker-compose.cypress.dev.yml Outdated Show resolved Hide resolved

ivangabriele added 7 commits February 20, 2024 17:14

Add missing execution rights on infra/docker/app/env.sh

3160114

Fix Wiremock local mappings path in docker compose files

96d5bc1

Remove unused infra/local/docker-compose-yml file

ccad37c

Fix docker-compose.puppeteer.dev.yml name

177fba8

Fix Wiremock local mappings path in docker compose files (bis)

4dc74ec

Remove unused DB_PUBLIC_PORT env var

909a395

Normalize env loading with .env.local.defaults + .env.local = .env st…

28a2e5e

…rategy

louptheron reviewed Feb 21, 2024

View reviewed changes

infra/.env.local.defaults Outdated Show resolved Hide resolved

Makefile Outdated Show resolved Hide resolved

infra/docker/app/env.sh Outdated Show resolved Hide resolved

louptheron reviewed Feb 21, 2024

View reviewed changes

Move /infra/.env.local.defaults file into /infra/docker

6b161b3

ivangabriele force-pushed the ivan/add-new-mission-button-in-control-unit-card branch from eff8749 to 32ce9af Compare February 21, 2024 14:12

Add ADR0003 about Docker & Frontend env vars strategy

69127d9

ivangabriele force-pushed the ivan/add-new-mission-button-in-control-unit-card branch from 32ce9af to 69127d9 Compare February 21, 2024 14:16

ivangabriele added 4 commits February 21, 2024 15:22

Rename env command to docker-env in Makefile

fe60814

Update ignore env files in .gitignore

8a7a842

Fix & upgrade MonitorEnv app in Puppeteer docker compose file

d565cad

Fix .env.example copy in app Dockerfile

f1b0c8e

ivangabriele force-pushed the ivan/add-new-mission-button-in-control-unit-card branch 4 times, most recently from ead2847 to e8c4fdb Compare February 21, 2024 19:24

Restore docker-compose-puppeteer-up command in Makefile

72093cd

ivangabriele force-pushed the ivan/add-new-mission-button-in-control-unit-card branch from e8c4fdb to 72093cd Compare February 21, 2024 19:58

ivangabriele merged commit 6b95923 into master Feb 21, 2024
27 checks passed

ivangabriele deleted the ivan/add-new-mission-button-in-control-unit-card branch February 21, 2024 23:40

coderabbitai bot mentioned this pull request Mar 7, 2024

Mission - Correction de bugs et amélioration de la sauvegarde en auto-save #3005

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Unités] Pouvoir créer une mission à partir d'une unité #2815

[Unités] Pouvoir créer une mission à partir d'une unité #2815

ivangabriele commented Jan 12, 2024 •

edited

Loading

louptheron Feb 14, 2024

ivangabriele Feb 14, 2024

louptheron left a comment

louptheron Feb 21, 2024

ivangabriele Feb 21, 2024 •

edited

Loading

sonarcloud bot commented Feb 21, 2024 •

edited

Loading

[Unités] Pouvoir créer une mission à partir d'une unité #2815

[Unités] Pouvoir créer une mission à partir d'une unité #2815

Conversation

ivangabriele commented Jan 12, 2024 • edited Loading

Linked issues

louptheron Feb 14, 2024

Choose a reason for hiding this comment

ivangabriele Feb 14, 2024

Choose a reason for hiding this comment

louptheron left a comment

Choose a reason for hiding this comment

louptheron Feb 21, 2024

Choose a reason for hiding this comment

ivangabriele Feb 21, 2024 • edited Loading

Choose a reason for hiding this comment

sonarcloud bot commented Feb 21, 2024 • edited Loading

Quality Gate passed

ivangabriele commented Jan 12, 2024 •

edited

Loading

ivangabriele Feb 21, 2024 •

edited

Loading

sonarcloud bot commented Feb 21, 2024 •

edited

Loading