Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Missions] Corrections de l'enregistrement automatique (ENV VAR UPDATE) #2838

Merged
merged 22 commits into from
Jan 31, 2024

Conversation

louptheron
Copy link
Collaborator

@louptheron louptheron commented Jan 23, 2024

Linked issues


  • Tests E2E (Cypress)

frontend/puppeteer/docker-compose.yml Dismissed Show dismissed Hide dismissed
frontend/puppeteer/docker-compose.yml Dismissed Show dismissed Hide dismissed
frontend/puppeteer/docker-compose.dev.yml Dismissed Show dismissed Hide dismissed
@louptheron louptheron marked this pull request as ready for review January 25, 2024 16:16
Copy link

gitguardian bot commented Jan 30, 2024

⚠️ GitGuardian has uncovered 11 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Generic Password d45dc5a frontend/puppeteer/docker-compose.yml View secret
- Generic Password 68bcca9 frontend/puppeteer/docker-compose.yml View secret
- Generic Password 68bcca9 frontend/puppeteer/docker-compose.yml View secret
- Generic Password d45dc5a frontend/puppeteer/docker-compose.yml View secret
- Generic Password 68bcca9 frontend/puppeteer/docker-compose.yml View secret
- Generic Password 68bcca9 infra/configurations/application-puppeteer.properties View secret
- Generic Password 68bcca9 frontend/puppeteer/docker-compose.dev.yml View secret
- Generic Password 68bcca9 frontend/puppeteer/docker-compose.dev.yml View secret
- Generic Password 68bcca9 frontend/puppeteer/docker-compose.yml View secret
- Generic Password 68bcca9 frontend/puppeteer/docker-compose.yml View secret
9429425 Triggered Generic Password b488fa0 infra/configurations/application-puppeteer.properties View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link
Member

@ivangabriele ivangabriele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super taff pour Puppeteer ^^.

De manière générale je ne suis vraiment pas fan d'avoir des envs + des docker files juste pour puppeteer (+ des scripts de start de l'app dans le package.json). Je trouve que notre app a de plus en plus de configs et d'environnements particuliers qui se couplent, ça fait vraiment beaucoup.

@louptheron louptheron changed the title [Missions] Corrections de l'enregistrement automatique [Missions] Corrections de l'enregistrement automatique (ENV VAR FRONTEND_IS_DEV_ENV) Jan 31, 2024
@louptheron louptheron changed the title [Missions] Corrections de l'enregistrement automatique (ENV VAR FRONTEND_IS_DEV_ENV) [Missions] Corrections de l'enregistrement automatique (ENV VAR UPDATE) Jan 31, 2024
@louptheron
Copy link
Collaborator Author

Rajouter les tags car le feature flag est désactivé

Copy link

sonarcloud bot commented Jan 31, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

16 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@louptheron louptheron merged commit 4991f0e into master Jan 31, 2024
25 checks passed
@louptheron louptheron deleted the loup/mission-auto-save-rework branch January 31, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Synchro missions – Revue avec enregistrement auto inactif
2 participants