Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Préavis] Tentatives d'amélioration de la base de code [DO NOT MERGE] #3277

Closed
wants to merge 26 commits into from
Closed

[Préavis] Tentatives d'amélioration de la base de code [DO NOT MERGE] #3277

wants to merge 26 commits into from

Conversation

ivangabriele
Copy link
Member

@ivangabriele ivangabriele commented Jun 12, 2024 •
edited
Loading

@ivangabriele
Add & integrate manual prior notifications SQL table
91af5ed
@ivangabriele
Add manual prior notification create & update in Backend
6652754
@ivangabriele
Fix many issues and refactor manual prior notifications in Backend
63af5c2
@ivangabriele
Add prior notification form in Frontend
250b10c
@ivangabriele
Update SQL migration file name index following rebase
0f2ca0e
@ivangabriele
Add missing trip gear codes in manual prior notification in Backend
b5a6a3a
@ivangabriele
Initialize prior notification sentAt form value with current date
bd38eb1
@ivangabriele
Add prior notification valid form submission logic & edition header
ba666a1
@ivangabriele
Fix mapping for swordfish & bluefin tuna cases in prior notification …
d901eb9 
…form
@ivangabriele
Remove unused report_datetime_utc column in new manual_prior_notifica…
d3cd547 
…tions SQL table
@ivangabriele
Add bluefin tuna & swordfish dummy manual prior notifications in test…
4bac197 
… data
@ivangabriele
Remove useless isLessThanTwelveMetersVessel filter in manual prior no…
99d5c58 
…tifications SQL query
@ivangabriele
Add missing trip segments in Backend manual prior notifications
4eba4c8
@ivangabriele
Add JpaManualPriorNotificationRepository inte tests
008a321
@ivangabriele
Fix DateRangePicker calendar popup width via monitor-ui upgrade
c1723d9
@ivangabriele
Update fishing catches field label in prior notification form
d63543b
@ivangabriele
Add prior notification form create & update e2e test
3539c00
@ivangabriele
Ensure specific fishing catches ordering in prior notification form
240282b
@ivangabriele
Fix test data for reporting e2e tests
3985c34
@ivangabriele
Fix missing cloning in prior notification form fishing catches field
3c8a48d
@ivangabriele
Fix unordered extended specy code cases in prior notification form
2455eaa
@ivangabriele
Add missing expected landing date validation in prior notification form
46ff324
@ivangabriele
Add prior notification form validation e2e test
ed48d56
@ivangabriele
Update Backend tests following test data update
4490c99
@ivangabriele
Refactor a few things following review in prior notification Backend
b96c08c
@ivangabriele
Abstract common prior notification & logbook report entities props in…
0fc8ce4 
… Backend
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 12, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ivangabriele ivangabriele mentioned this pull request Jun 12, 2024
Merged
1 task
@ivangabriele
Copy link
Member Author

La plupart de ce code a été réécrit sur master maintenant.

@ivangabriele ivangabriele deleted the ivan/add-prior-notification-form-refactoring-attempts branch August 12, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ivangabriele