Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech - Ajout de keycloak et sécurisation des APIs (UPDATE ENV VAR) #3501

Merged
merged 8 commits into from
Aug 14, 2024

Conversation

louptheron
Copy link
Collaborator

@louptheron louptheron commented Aug 8, 2024

Linked issues

To Do en PROD

Rajouter dans le .monitorfish :

  • MONITORFISH_OIDC_LOGOUT_REDIRECT_URI=https://www.mer.gouv.fr

Mettre à jour le docker-compose :

- FRONTEND_OIDC_LOGOUT_REDIRECT_URI=$MONITORFISH_OIDC_LOGOUT_REDIRECT_URI

  • Tests E2E (Cypress)

@louptheron louptheron force-pushed the loup/add_keycloak_securize_apis branch from b6da267 to 2e3b890 Compare August 9, 2024 09:40
@louptheron louptheron marked this pull request as ready for review August 9, 2024 09:40
@louptheron louptheron force-pushed the loup/add_keycloak_securize_apis branch from 2e3b890 to 6c51739 Compare August 9, 2024 14:20
@louptheron louptheron changed the title Tech - Ajout de keycloak et sécurisation des APIs Tech - Ajout de keycloak et sécurisation des APIs (UPDATE ENV VAR) Aug 12, 2024
@louptheron louptheron force-pushed the loup/add_keycloak_securize_apis branch from 6c51739 to 25a4b98 Compare August 12, 2024 06:26
Copy link

gitguardian bot commented Aug 12, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9429425 Triggered Generic Password e521eef infra/docker/docker-compose.cypress.yml View secret
9429425 Triggered Generic Password c3a084f infra/docker/docker-compose.cypress.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@louptheron louptheron force-pushed the loup/add_keycloak_securize_apis branch from 7151eec to c0c23fe Compare August 13, 2024 09:48
Copy link

sonarcloud bot commented Aug 14, 2024

@louptheron louptheron merged commit 206cb9d into master Aug 14, 2024
26 checks passed
@louptheron louptheron deleted the loup/add_keycloak_securize_apis branch August 14, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cerbère - Restreindre l'accès fleet_segments à superUser
2 participants