Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker/build-push-action to cache docker build #1696

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

alastair
Copy link
Member

Description
Now that we use docker buildx in the unit tests, use the docker/build-push-action to allow us to use docker's built-in layer cache when running tests.

This also builds the base image manually instead of using make, as the makefile now contains both the py2 and py3 base images and we only need the py3 one.

I manually build the worker image (to cache it), and then run docker-compose build again to correctly tag it. Theoretically this should use existing layers and then tag the image as expected.

I use 2 "cache images" in the github docker cache. This should make the caching operation quite fast because it stays within github instead of going to docker hub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant