Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom management command that sets an announcement banner on front page #1781

Merged
merged 8 commits into from
Jun 20, 2024

Conversation

Bomme
Copy link
Contributor

@Bomme Bomme commented Jun 18, 2024

needs more styling

Issue(s)

Description

Deployment steps:

@Bomme Bomme requested a review from ffont June 18, 2024 08:06
@alastair alastair linked an issue Jun 18, 2024 that may be closed by this pull request
Copy link
Member

@ffont ffont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bomme! I left a couple of comments and I'll work on the styling part. I also think there's some missing change in the view of the front page where the contents of announcement_cache are passed to the front page template. I guess you did not commit that file?

general/management/commands/announcement_cache.py Outdated Show resolved Hide resolved
general/management/commands/announcement_cache.py Outdated Show resolved Hide resolved
@Bomme
Copy link
Contributor Author

Bomme commented Jun 18, 2024

@ffont I addressed your comments and added the missing line!

@ffont
Copy link
Member

ffont commented Jun 19, 2024

Cool! I added the styling. Also renamed the management command to announcement_banner which I think will be easier to remember. You can try if you want and think of a text for your own announcement. I would use no title, I think there's no need. After my updated, you can pass empty title and the message will be rendered fine.

Once you test it and tell me it is ok (and try with texts for your announcement), then we can merge, deploy and add your banner.

@ffont ffont merged commit ff6200d into master Jun 20, 2024
1 check passed
@ffont ffont deleted the announcement_banner branch June 20, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site-wide notification system
2 participants