Starter issues solving - reply message + change bookmark category + space for usernames #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
done: creation of edit_modal.html and user interface in the bookmarks page. missing: it does not execute the request.method==POST part in view.py -> change_bookmark_category
improvements to be made: show error message inside edit modal in case the category already exists
quimmrc
changed the title
quimmrc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s)
#1755
#1577
Description
Changes in replies' definition of the recepient. Decide who will be the recepient according to who is requesting the reply message (request.user)
Addition of "edit_modal" to allow changes in category bookmark names, and a user interface to allow so. Bookmark category change allowed + checking that category name does not already exists.
Improvements to be made: show possible errors in modal dialog