Do not verify API SSL #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MTrab, it may be worth considering if a configuration should be added allowing the enduser to actively deactivate SSL validation - should such a case like this occur in the future. |
|
I agree with @henriklund ; make it optional, as part of the configuration. Pushing a update to simply ignore the API SSL validation are a bit... odd, even though Energinet was facing some issues with the certs (possibly?). |
|
Lets just get this change reverted, then we deal with adding a configuration option later. |
|
Will look into this when back from holiday - nothing will happen for at least one week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix API SSL certificate validity errors/issues, disable SSL verification