enable omission of teacher's name for term independent lectures

app/controllers/lectures_controller.rb

@@ -264,6 +264,7 @@ def lecture_params
                                     :start_section, :organizational, :locale,
                                     :organizational_concept, :muesli,
                                     :organizational_on_top,
+                                    :disable_teacher_display,
                                     :content_mode, :passphrase, :sort,
                                     :comments_disabled,
                                     editor_ids: [])

app/models/lecture.rb

@@ -370,6 +370,7 @@ def title_term_info
   end
 
   def title_term_info_no_type
+    return course.title unless term
     "#{course.title}, #{term_to_label}"
   end
 

app/views/courses/_image.html.erb

@@ -31,7 +31,7 @@
         <div class="row mb-3">
           <div class="col-12">
             <%= image_tag(course.image_url_with_host.presence ||
-                            '/teachable_thumbnail.png',
+                            '/no_course_information.png',
                           class: 'img-fluid',
                           id: 'image-preview') %>
           </div>

app/views/lectures/edit/_preferences.html.erb

@@ -146,6 +146,22 @@
               </div>
             </div>
           </div>
+          <% if !lecture.term %>
+            <div class="row">
+              <div class="col-12">
+                <div class="custom-control custom-checkbox">
+                  <%= f.check_box :disable_teacher_display,
+                                  class: 'custom-control-input',
+                                  disabled: inspection %>
+                  <%= f.label :disable_teacher_display,
+                              t('admin.lecture.disable_teacher_display'),
+                              { class: 'custom-control-label' } %>
+                  <%= helpdesk(t('admin.lecture.info.disable_teacher_display'),
+                             false) %>
+                </div>
+              </div>
+            </div>
+          <% end %>
           <div class="row">
             <div class="col-12 text-center">
               <div id="lecture-preferences-warning">

app/views/lectures/show.html.erb

@@ -7,12 +7,14 @@
       <span id="lecture-title" class="mr-3">
         <%= @lecture.title_term_info_no_type %>
       </span>
-      <span>
-        <%= link_to @lecture.teacher.name,
-                    teacher_path(@lecture.teacher),
-                    id: 'lecture-teacher',
-                    class: 'text-dark' %>
-      </span>
+      <% if @lecture.term || !@lecture.disable_teacher_display %>
+        <span>
+          <%= link_to @lecture.teacher.name,
+                      teacher_path(@lecture.teacher),
+                      id: 'lecture-teacher',
+                      class: 'text-dark' %>
+        </span>
+      <% end %>
       <% privileged = current_user.admin ||
                       current_user.in?(@lecture.editors_with_inheritance) %>
       <%= link_to '',

app/views/main/start/_lecture_card.html.erb

@@ -47,19 +47,23 @@
           <% if !current && lecture.term %>
             <%= lecture.term.to_label_short %>,
           <% end %>
-          <%= lecture.teacher.name %>
+          <% if lecture.term || !lecture.disable_teacher_display %>
+            <%= lecture.teacher.name %>
+          <% else %>
+            <br>
+          <% end %>
       </div>
     </div>
   </div>
   <% if subscribed %>
      <%= link_to image_tag(lecture.course.normalized_image_url_with_host ||
-                             '/teachable_thumbnail.png',
+                             '/no_course_information.png',
                           class: 'card-img-top teachableThumbnail border-bottom',
                           alt: 'Card image cap'),
                  lecture %>
   <% else %>
     <%= image_tag(lecture.course.normalized_image_url_with_host ||
-                    '/teachable_thumbnail.png',
+                    '/no_course_information.png',
                   class: 'card-img-top teachableThumbnail border-bottom',
                   alt: 'Card image cap') %>
   <% end %>

config/locales/de.yml

@@ -345,6 +345,7 @@ de:
       new_posts: 'neue Forenbeiträge'
       no_rights: >
         Du hast keine Berechtigung, diese Veranstaltung zu abonnieren.
+      disable_teacher_display: Anzeige des DozentInnen-Namens unterdrücken
       info:
         course: >
           Hier kannst Du das Modul auswählen, zu dem diese
@@ -553,6 +554,12 @@ de:
           Hier kannst Du Text eingeben, nach dem im Titel der Veranstaltung
           gesucht wird. Wenn Du dieses Feld leer lässt (bzw. weniger als zwei Buchstaben
           eingibst), wird es bei der Suche ignoriert.
+        disable_teacher_display: >
+          Wenn Du dieses Feld aktivierst, wird auf der Vorlesungs-Karten auf der
+          Startseite und auf der Vorlesungsseite für generische Nutzer
+          der DozentInnen-Name nicht angezeigt. Das macht z.B. Sinn, wenn
+          eine semesterunabhängige Veranstaltung von jemandem nur administrativ
+          als "DozentIn" begleitet wird.
       show_media: 'Medien einblenden'
       workflow: 'Workflow'
       content_mode: 'Inhaltsermittlung'

config/locales/en.yml

@@ -334,6 +334,7 @@ en:
       new_media: 'new media'
       new_posts: 'new forum posts'
       no_rights: 'You are not authorized to subscribe this event series.'
+      disable_teacher_display: disable the display of the teacher's name
       info:
         course: >
           Here you can select the course to which this event series belongs.
@@ -520,6 +521,11 @@ en:
           Here you can enter text that will be searched for in the title of the
           event series. If you leave the text field empty (or enter less than two letters),
           it will be ignored.
+        disable_teacher_display: >
+          If you check this box, the teacher's name will be omitted from the
+          lecture card on the start page and from the lecture page for generic
+          users. This could make sense e.g. if a lecture that is term
+          independent is only administratively supervised by a "teacher".
       show_media: 'Show media'
       workflow: 'Workflow'
       content_mode: 'Content determination'

db/migrate/20200907113337_add_disable_teacher_display_to_lecture.rb

@@ -0,0 +1,5 @@
+class AddDisableTeacherDisplayToLecture < ActiveRecord::Migration[6.0]
+  def change
+    add_column :lectures, :disable_teacher_display, :boolean, default: false
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 2020_09_03_152249) do
+ActiveRecord::Schema.define(version: 2020_09_07_113337) do
 
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
@@ -264,6 +264,7 @@
     t.text "structure_ids"
     t.boolean "comments_disabled"
     t.boolean "organizational_on_top"
+    t.boolean "disable_teacher_display", default: false
     t.index ["teacher_id"], name: "index_lectures_on_teacher_id"
     t.index ["term_id"], name: "index_lectures_on_term_id"
   end