Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoloring of commentsIcon does not work #474

Closed
fosterfarrell9 opened this issue Apr 24, 2023 · 0 comments · Fixed by #475
Closed

Decoloring of commentsIcon does not work #474

fosterfarrell9 opened this issue Apr 24, 2023 · 0 comments · Fixed by #475
Assignees
Labels

Comments

@fosterfarrell9
Copy link
Collaborator

fosterfarrell9 commented Apr 24, 2023

If you resolve all comments on the /main/comments page by clicking the corresponding button (alternatively, the last remaining comment), the #commentsIcon keeps its yellow color (until the next page load) instead of becoming white again immediately. The reason is that this is handled in app/views/readers/update_all.coffee (resp. app/views/readers/update.coffee) via

$('#commentsIcon').removeClass('text-primary').addClass('text-light')

but the coloring is no longer given by the text-primary class in the new navbar. So, the fix should be pretty easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants