Fix decoloring of comments icon

[Splines]

• What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  Fixes Decoloring of commentsIcon does not work #474

[Splines]

In addition to app/views/readers/update_all.coffee and app/views/readers/update.coffee, I also changed these lines in app/views/comments/create.js.erb:

<% if @update_icon %>
$('#commentsIcon').addClass('new-comment');
<% end %>

While doing this, I was wondering if we really want the comments icon to be colored at all when you submit your own comment. Isn't it a bit weird for a user to then click on the icon just to notice it was their own comment 3 seconds ago?

[fosterfarrell9]

While doing this, I was wondering if we really want the comments icon to be colored at all when you submit your own comment. Isn't it a bit weird for a user to then click on the icon just to notice it was their own comment 3 seconds ago?

We could discuss this. I mean, for me personally, I like to have this coloring even for my own comments, because it gives me some more visual feedback that I did something that other users will notice. Of course, others might disagree with that view.
By the way, for any changes in that direction, #445 should be resolved first, because the code responsible for selecting who gets a coloring is inside the comments_controller.rb in the commontator gem which we currently self-host. It would be better to have this back as a custom controller inside our own repository.

[Splines]

@fosterfarrell9 Of course, that's very subjective. Personally, I want to be notified when another user has made a comment (or even more urgent when somebody else replied to my own comment). For this to work, once I've left a comment, I have to click on the now colorized comments icon and then on either "Clear all" or "Clear" for my own comment. If I don't repeat this for every comment I post, the icon stays colorized and I won't notice that somebody else has posted something.

But we should probably outsource this discussion to an issue (if at all) as this PR is now just intended for this fix ;)

[Splines]

Before squashing, I will look again into the integration tests and find out why they are failing here.

[codecov]

Codecov Report

Merging #475 (47e44fe) into mampf-next (263a355) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           mampf-next     #475   +/-   ##
===========================================
  Coverage       66.64%   66.64%           
===========================================
  Files             311      311           
  Lines            9363     9363           
===========================================
  Hits             6240     6240           
  Misses           3123     3123