Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong media types in quiz editor #496

Open
fosterfarrell9 opened this issue May 10, 2023 · 2 comments
Open

Wrong media types in quiz editor #496

fosterfarrell9 opened this issue May 10, 2023 · 2 comments
Assignees
Labels

Comments

@fosterfarrell9
Copy link
Collaborator

The search form in the quiz editor which is used for selection of questions/remarks in a quiz now has an "all" media button. When this is selected, media of all types (not only questions and reamrks) are searched, but hovering over the results (of wrong type) then results in an exception:

 undefined method `locale_with_inheritance' for nil:NilClass I18n.locale = @quizzable.locale_with_inheritance 

/usr/src/app/app/controllers/media_controller.rb:488:in `fill_quizzable_preview'

The "all" button should be removed in this form, and exception handling should be improved.

@fosterfarrell9 fosterfarrell9 self-assigned this May 11, 2023
@fosterfarrell9
Copy link
Collaborator Author

Also, searching Questions as a non-admin editor or teacher will not give any results; and in the media search in the admin area, you cannot even select "questions as type. These are all regressions introduced in #420.

@Splines
Copy link
Member

Splines commented Jun 7, 2023

@fosterfarrell9 Did you fix all aspects of this issue in #506?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants