Media search #420
Merged
Media search #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
option to change between list and card display
should not be accessible to normal user
removed "subscribed and preceding" option better phone layout
using the "or" operator now executes two searches, one where the tags are included and one where they are ignored. they are then combined so that those with the selected tags are shown first in the results. also fixed the search with the "and" operator.
-fix issues with wrong pagination due to the two concurrent medium searches -also filter search results for user visibility if access search_parameter is left blank
of controller tests
request tests for media search remove unnecessary testing gem init helpers for request tests
fosterfarrell9
requested changes
Jan 4, 2023
app/controllers/media_controller.rb
Outdated
| @@ -207,17 +211,49 @@ def inspect | |||
| # return all media that match the search parameters | |||
| def search | |||
| authorize! :search, Medium.new | |||
|
|
|||
| # get all media, then set them to only those that are visible to the current user | |||
| if search_params[:access].blank? | |||
There was a problem hiding this comment.
If generic users manipulate their search form and add some non-blank entry for the access parameter, they will see unfiltered results, since the filtering is triggered by filter_media, see line 240. This should be prevented. I think they should always be filtered for non-gneric users.
This was referenced May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generic user search for media (on start page)
Allows for different filtering criteria to be selected (tags, description, teacher, lecture, etc.)
Consistent with admin search if same criteria chosen
Also setup for request tests and implementation for media search
Fixes of some unrelated cypress tests
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: