Fix tests #472
Merged
Fix tests #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update checkout action to version v3 - Use new docker layer caching version - Simplify commands to handle docker compose shell commands - Update codecov action
Codecov Report
@@ Coverage Diff @@
## mampf-next #472 +/- ##
==============================================
+ Coverage 65.44% 66.65% +1.21%
==============================================
Files 302 311 +9
Lines 8965 9360 +395
==============================================
+ Hits 5867 6239 +372
- Misses 3098 3121 +23
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Splines
approved these changes
Apr 23, 2023
|
|
||
| - name: Pull docker images | ||
| run: docker compose pull --ignore-buildable | ||
| working-directory: docker/run_cypress_tests |
There was a problem hiding this comment.
Maybe rename the folder to docker/run_tests as it is not specifically for Cypress tests anymore.
|
Yes #441 can be closed, I cherry-picked one of your commits. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix all checks. Tests are executed sequentially to utilize cache.
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: