-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce new ESLint rules for all .js and .js.erb files #575
Conversation
Command used: `yarn run eslint --fix .` Still 47 problems (27 errors, 20 warnings) after this.
As of a8fc972, our codebase is now fully compliant with the ESLint rules we've set up. |
This PR is now ready to be reviewed. Note that regarding testing the frontend, I've only performed some quick manual checks, e.g. made sure the login works, I can click on lectures, see a video and edit some attributes as a lecturer, e.g. add a new homework assignment. Note that I'd love to have When reviewing you might want to use the VSCode diff view instead as GitHub does not correctly displays some changes, e.g. when we deleted tabs it shows it as deleted and added line instead of a modification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I also played around a lot with things that could be effected by the refactorization of _selectize_turbolinks_fix.js
, but everything seems to work nicely.
* Add cypress rules to ESLint & ignore some patterns * Allow usage of tempusDominus global variable * Ignore JS files with Sprocket syntax * Further improve rules, e.g. allow common globals * Ignore sprocket syntax in cable.js * Autofix all `.js` and `.js.erb` files Command used: `yarn run eslint --fix .` Still 47 problems (27 errors, 20 warnings) after this. * Fix variables in turbolink fix * Prepend unused variables with "_" * Get rid of unused widget variable * Fix specs comment tab alignment
Enforces the JavaScript style rules introduced in #568. Note that new rules are added/customized in this PR to better reflect the reality of our codebase.