Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rubocop version and enforce all cops #617

Merged
merged 5 commits into from
Apr 17, 2024
Merged

Update Rubocop version and enforce all cops #617

merged 5 commits into from
Apr 17, 2024

Conversation

Splines
Copy link
Member

@Splines Splines commented Apr 15, 2024 •
edited by fosterfarrell9
Loading

Commands used to run Rubocop

bundle exec rubocop --autocorrect --disable-uncorrectable
bundle exec rubocop -A  # in a second run

For reviewers

  • You have to run bundle install locally to install the new versions.
  • Please review the unsafe cops carefully as they might introduce breaking behavior. E.g. the autocorrection of Style/MapIntoArray failed for us because we return an object and not an array. I fixed that, also see the commit body of afccc70.
  • Note that I disabled one potential fix in a migration file as we don't want to alter db migration files once they've already been deployed to production.

Splines added 3 commits April 15, 2024 22:59
@Splines
Update Rubocop (and plugins) to latest versions
e476bec
@Splines
Autocorrect safe cops
c9c28fa 
One rule was disabled since we don't want to alter already performed
migrations.
@Splines
Autocorrect unsafe cops
afccc70 
Special care is needed for `tag.rb` around line 190.
The autofix did not produce a valid result, I had to put extra
curly braces around that line as we want to push an object to the array.
@Splines Splines added the dependencies Pull requests that update a dependency file label Apr 15, 2024
@Splines Splines self-assigned this Apr 15, 2024
@Splines Splines mentioned this pull request Apr 15, 2024
Merged
14 tasks
@Splines Splines marked this pull request as ready for review April 15, 2024 21:20
@Splines Splines requested a review from fosterfarrell9 April 15, 2024 21:21
fosterfarrell9
fosterfarrell9 previously approved these changes Apr 16, 2024
View reviewed changes
@Splines
Remove unnecessary Unique validation RuboCop TODO
456239f 
They probably got unnecessary due to the update of RuboCop, though I
haven't looked into their changelog to confirm.
@Splines Splines requested a review from fosterfarrell9 April 17, 2024 13:12
@Splines Splines merged commit dfdad5d into dev Apr 17, 2024
3 checks passed
@Splines Splines deleted the deps/update-rubocop branch April 17, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fosterfarrell9 fosterfarrell9 fosterfarrell9 approved these changes

Assignees

@Splines Splines

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Splines @fosterfarrell9