Pin thredded to recent Git commit
#643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #609, we had to use an older version of
html-parser(see commit 456ed14) for the forum enginethreddedto still work with Rails 7.1. This was necessary due to thredded/thredded#979. In the meantime, glebm made a commit onthreddedto deal with this internally in their project, so we don't need to include the dependencyhtml-parseron our side (see thredded/thredded#981). Therefore, we get rid ofhtml-parserand use the new commit from their GitHub repo directly.For reviwers
bundle installlocally.docker compose build mampf webpacker, otherwise bundler is complaining in the Docker images.If you happen to know a way to avoid rebuilding the whole image if we just update some gems let me know since rebuilding always takes quite some time and I'd like to avoid that. I'm also wondering why this is even the case after having run
bundle installonly locally; why is Bundler complaining in the Docker container after that? I thought it has its own dependencies installed inside the docker container...