Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open interactive area if chapters or references are present in video #644

Merged
merged 1 commit into from
May 26, 2024

Conversation

Splines
Copy link
Member

@Splines Splines commented May 22, 2024

This fixes #638.

For reviewers

In the code, probably due to historic reasons, references are referred to by "metadata" while chapters are called under the name "chapters".

  • Interactive area should be closed if neither chapters nor references are present (1 case)
  • Interactive area should be opened if either chapters or references are present (3 possible cases)
  • Interactive area itself should still work as usual, e.g. users should be able to open/close it by pressing the button, or by using the keyboard shortcut i. The interactive area should display the elements just as was before.

Note that the interactive area might be opened even though no element is shown. This is by design: references can pop up at a later point in time in the video. If any reference is present (no matter the timestamp), the interactive area will already be opened for users to take note that a reference just appeared.

This comment was marked as off-topic.

@Splines Splines merged commit 77040f6 into dev May 26, 2024
6 checks passed
@Splines Splines deleted the feature/video-player-references-and-toc branch May 26, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants