Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint to skip validation in Cypress tests #669

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

Splines
Copy link
Member

@Splines Splines commented Aug 4, 2024

In this PR we

  • add an endpoint to skip the validation in the FactoryBot create() method. The function can be called from Cypress tests via FactoryBot.createNoValidate(...)
  • expose Docker to another port (externally) to be able to start Cypress while the dev environment is running. The internal Docker port stays 3000.

@Splines Splines added the tests Unit tests, integration tests etc. label Aug 4, 2024
@Splines Splines self-assigned this Aug 4, 2024
@Splines Splines marked this pull request as ready for review August 10, 2024 23:47
@Splines Splines requested a review from fosterfarrell9 August 10, 2024 23:47
Copy link

codecov bot commented Aug 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (dev@742ee15). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #669   +/-   ##
======================================
  Coverage       ?   53.09%           
======================================
  Files          ?      153           
  Lines          ?     6614           
  Branches       ?        0           
======================================
  Hits           ?     3512           
  Misses         ?     3102           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Splines Splines merged commit 4a0e103 into dev Aug 12, 2024
7 of 9 checks passed
@Splines Splines deleted the tests/cypress-skip-validation branch August 12, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Unit tests, integration tests etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants