Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gemfile dependencies (bundle update) #688

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Conversation

Splines
Copy link
Member

@Splines Splines commented Aug 22, 2024

I ran bundle update to update our dependencies according to our Gemfile (which I cleaned up recently in #680 and pinned Gems there). Might be worth checking out if there are new major versions for some gems (in a future PR).

I also updated my local bundler version by executing bundle update --bundler. You can see this in the last line in the Gemfile.lock. The newest version is 2.5.17, released on August 1, 2024.

TODO for myself & reviewers

  • Check that everything is still working with the new dependencies.
    We should probably not encounter any problems as we pinned the gems in Clean up Gemfile & pin all gems #680, such that they only undergo automatic minor version upgrades. There could still be a bad apple somewhere...

@Splines Splines added the dependencies Pull requests that update a dependency file label Aug 22, 2024
@Splines Splines requested a review from fosterfarrell9 August 22, 2024 23:27
@Splines Splines self-assigned this Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.86%. Comparing base (d48e369) to head (2057f46).
Report is 6 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #688   +/-   ##
=======================================
  Coverage   53.86%   53.86%           
=======================================
  Files         157      157           
  Lines        6645     6645           
=======================================
  Hits         3579     3579           
  Misses       3066     3066           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fosterfarrell9
fosterfarrell9 previously approved these changes Aug 29, 2024
@Splines
Copy link
Member Author

Splines commented Sep 5, 2024

@fosterfarrell9 Good that we have tests: the update for the js-routes gem here broke MaMpf and you couldn't access some pages in the frontend anymore since Routes. ... was not defined anymore for JavaScript files. Some cypress tests detected this, e.g. your test that the lecture page shows a button.

Instead of fixing the underlying problem during the update, I've pinned js-routes to the older version. This is because there is already a new major version and I don't see the point in investing time here in upgrading a minor version if we could just as well upgrade to the major version soon, see #690.

Copy link
Collaborator

@fosterfarrell9 fosterfarrell9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Splines Splines merged commit 5caf307 into dev Sep 19, 2024
5 checks passed
@Splines Splines deleted the deps/update-gemfile branch September 19, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants