Add just docker rebuild command
#719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually `click()` should already do this for us I thought.
|
Could you possibly add an option for an attached mode? |
I've removed the startup command such the command really only does what it sais: rebuild the containers. If you still want to start the containers afterwards, chaining of commands should work, e.g. Note that I won't run through the tests as we don't have tests for |
fosterfarrell9
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
just docker rebuildcommand that rebuilds MaMpf (and webpacker if the env is set totest, e.g.just docker rebuild test). Note thatjust docker rebuild env="test"is not working as command due to limitations ofjust, see casey/just#476.Off-topic: also deleted an unnecessary comment.