Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete tutorial name search field #728

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

fosterfarrell9
Copy link
Collaborator

@fosterfarrell9 fosterfarrell9 commented Dec 14, 2024

In our User model, we have the following searchable related to Solr searches:

searchable do
  text :tutorial_name
end

There is however no longer any Solr based search for users (and has not been for a long time). The search field was introduced in this commit, and at a later time the search field was changed to tutorial_name. However, this was only used in the users controller in a list method which no longer exists. All user based searches have long since been changed to Postgres searches. If you search for Sunspot.new_search in our code base, you will see that there are no longer any Solr based searches on the user model.
Consequently, this PR removes the obsolete searchable field from the User model.

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.27%. Comparing base (9dcd2b9) to head (f6caf09).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #728      +/-   ##
==========================================
- Coverage   54.28%   54.27%   -0.02%     
==========================================
  Files         170      170              
  Lines        7346     7344       -2     
==========================================
- Hits         3988     3986       -2     
  Misses       3358     3358              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Splines Splines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I've searched for various combinations of user and search and didn't find any remnants.

Please squash and merge after the tests have run through.

@fosterfarrell9 fosterfarrell9 merged commit da59363 into dev Dec 14, 2024
4 checks passed
@fosterfarrell9 fosterfarrell9 deleted the fix/remove-obsolete-search-field branch December 14, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants