Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add design docs #1

Merged
merged 30 commits into from
Nov 24, 2023
Merged

Add design docs #1

merged 30 commits into from
Nov 24, 2023

Conversation

inbarbarkai
Copy link
Collaborator

No description provided.

@inbarbarkai inbarbarkai added the documentation Improvements or additions to documentation label Sep 5, 2023
@yarons
Copy link
Contributor

yarons commented Sep 7, 2023

I'm looking at all the possible ways of generating documentation, there are several:

  1. Using some online converter that doesn't require any GH Actions: https://github.com/jonashackt/plantuml-markdown - requires separating the UML from the Markdown.
  2. GH Actions (Which I'm still trying to understand how to deploy to GitHub Pages/Wiki when done): https://github.com/marketplace/actions/generate-plantuml - it only creates SVG out of the UMLs you already have and replaces the @plantuml expression with the SVG that was generated next to it.
  3. Switch to GitLab.
  4. Switch to Mermain.

@inbarbarkai
Copy link
Collaborator Author

inbarbarkai commented Sep 7, 2023

Mermaid does not support the features I used in PlantUML.
I don't see myself changing tools to write documentation.

I have no issue with separating the diagrams from the markdown, just point me to an explanation on how.

@yarons
Copy link
Contributor

yarons commented Sep 8, 2023

OK So we're looking at options 1 or 2.
The link in option 1 explaining the separation assuming we're choosing this path.
Option number 2 creates an additional folder for the generated SVG files and links the relevant sections in the MD to this SVG image as an external resource.
Those 2 links explain everything we need to do to make it work, I'll just need to adjust it for some tests and possibly set your branch to the documentation branch instead of the main one.
The official GitHub Pages offering focuses on Jekyll, which is pretty neat and also has a plugin that supports PlantUML.

This is my ChatGPT about this subject (I narrowed down the option and for some reason the implementation transformed drastically): https://chat.openai.com/share/47acfe3b-be0d-4bc5-94df-d9a891805262

@yarons
Copy link
Contributor

yarons commented Sep 10, 2023

As discussed, we'll skip the first option to avoid collisions due to branch naming, I'll work on that.

@yarons yarons temporarily deployed to github-pages September 10, 2023 11:46 — with GitHub Pages Inactive
Jekyll Theme.
@yarons yarons temporarily deployed to github-pages September 10, 2023 11:50 — with GitHub Pages Inactive
Cannot mix branches, sorry.
Changed to correct working directory.
@yarons yarons temporarily deployed to github-pages September 11, 2023 06:41 — with GitHub Actions Inactive
Corrected the other directory.
@yarons yarons temporarily deployed to github-pages September 11, 2023 06:44 — with GitHub Actions Inactive
Generated a whole new jobs section.
Adding Jekyll PlantUML plugin for parsing
@yarons yarons temporarily deployed to github-pages September 12, 2023 06:57 — with GitHub Pages Inactive
@yarons yarons temporarily deployed to github-pages September 12, 2023 07:03 — with GitHub Pages Inactive
@yarons yarons temporarily deployed to github-pages September 12, 2023 07:06 — with GitHub Pages Inactive
Copy link
Contributor

@yarons yarons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, it looks great, I'd like to talk to you about the current architecture and what are the advantages of this proposal, thanks :)

@inbarbarkai inbarbarkai marked this pull request as ready for review November 24, 2023 09:17
@inbarbarkai inbarbarkai merged commit ae6cc12 into main Nov 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants