Don't leak opts as a global variable.
#13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing the plugin to break for me. It appears one of the other modules that I am using is leaking a variable of the same name.
|
Thank you for pointing this out 👍 Such a silly mistake on my part and I am sorry that it cost you time. I have released v0.3.9 which fixes this issue and pushed to npm. |
|
That's alright mate. Thanks for the great work 😄 On Mon, 29 Jun 2015 17:22 Eric Eastwood notifications@github.com wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing the plugin to break for me. It appears one of the other modules that I am using is leaking a variable of the same name.