Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatability with standard SS calls #78

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Compatability with standard SS calls #78

merged 1 commit into from
Apr 19, 2022

Conversation

lbradley-mm
Copy link
Contributor

Mark as Deprecated

hpatel-mm
hpatel-mm requested changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@hpatel-mm hpatel-mm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎 please don't change the Cloudinary based names. make new functions for backwards compatibility. There's already scale related methods inside the scale trait.

@lbradley-mm lbradley-mm merged commit f1caa05 into widget Apr 19, 2022
@lbradley-mm lbradley-mm deleted the compatability-ss branch April 19, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hpatel-mm hpatel-mm hpatel-mm approved these changes

@vipen-made vipen-made Awaiting requested review from vipen-made

@mrai-mm mrai-mm Awaiting requested review from mrai-mm

@lthornton-mm lthornton-mm Awaiting requested review from lthornton-mm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lbradley-mm @hpatel-mm