Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR :: Request의 요일 정보를 한글로 입력 #199

Merged
merged 7 commits into from
Apr 12, 2024
Merged

PR :: Request의 요일 정보를 한글로 입력 #199

merged 7 commits into from
Apr 12, 2024

Conversation

Daybreak312
Copy link
Member

어떤 종류의 PR 인가요?

이 PR이 무슨 일을 하나요? / 필요한 이유가 뭔가요?

  • Flutter 측의 요청으로, 요일 정보를 한글 문자열로도 입력 받을 수 있도록 수정했습니다.
  • Routine을 생성 및 수정할 때, 해당 루틴을 보관함에도 (사용하지 않을 예정임에도) 현재 사용중인 루틴들과 요일이 겹치는지 확인하게 되어 다소 귀찮은 일이 발생해, 이러한 문제점을 해결했습니다.

리뷰어를 위한 참고사항:

코드를 보시면 어느정도 짐작 가능하시다시피, 이전의 방법(영어 DayOfWeek)으로도 요청 가능합니다.

@Daybreak312 Daybreak312 self-assigned this Apr 12, 2024
@Daybreak312 Daybreak312 added kind/기능 functional development kind/리펙토링 refactoring code labels Apr 12, 2024
@Daybreak312 Daybreak312 merged commit ebd22b9 into develop Apr 12, 2024
2 checks passed
@Daybreak312 Daybreak312 deleted the Request의_요일들을_한글로_입력 branch April 12, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyunSu1768 HyunSu1768 Awaiting requested review from HyunSu1768 HyunSu1768 is a code owner

@gurdl0525 gurdl0525 Awaiting requested review from gurdl0525 gurdl0525 is a code owner

@pokabook pokabook Awaiting requested review from pokabook pokabook is a code owner

Assignees

@Daybreak312 Daybreak312

Labels
kind/리펙토링 refactoring code kind/기능 functional development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Daybreak312