Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR :: 내 목표 조회 API 구현 #208

Merged
merged 6 commits into from
Apr 20, 2024

Conversation

Daybreak312
Copy link
Member

어떤 종류의 PR 인가요?

/kind 기능
/kind 리펙토링

이 PR이 무슨 일을 하나요? / 필요한 이유가 뭔가요?

  • 내 목표 조회 API를 구현했습니다.
  • 내 루틴 조회 API를 Pagenation으로 수정했습니다.

리뷰어를 위한 참고사항:

전체 조회 -> Paged 조회로 수정되었기 때문에, API Path가 수정되었습니다.(me/all -> my)

@Daybreak312 Daybreak312 self-assigned this Apr 20, 2024
@maeumgagym-ci-robot-app maeumgagym-ci-robot-app bot added kind/기능 functional development kind/리펙토링 refactoring code labels Apr 20, 2024
@maeumgagym-ci-robot-app
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Daybreak312

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gurdl0525
Copy link
Member

/lgtm

@maeumgagym-ci-robot-app maeumgagym-ci-robot-app bot added the lgtm Looks good to me label Apr 20, 2024
@maeumgagym-ci-robot-app maeumgagym-ci-robot-app bot merged commit 8e5da44 into develop Apr 20, 2024
3 checks passed
@maeumgagym-ci-robot-app maeumgagym-ci-robot-app bot deleted the 내-목표-조회-API-구현 branch April 20, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/리펙토링 refactoring code kind/기능 functional development lgtm Looks good to me size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants