Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR :: 문서화 추가 #212

Merged
merged 5 commits into from
May 2, 2024
Merged

PR :: 문서화 추가 #212

merged 5 commits into from
May 2, 2024

Conversation

Daybreak312
Copy link
Member

어떤 종류의 PR 인가요?

/kind 문서

이 PR이 무슨 일을 하나요? / 필요한 이유가 뭔가요?

  • LocationHeaderInterceptor의 메소드에 KDocs를 작성했습니다.
  • AccessManager 및 관련 모듈에 대한 관계 다이어그램을 작성했습니다.
  • 모듈 -> 패키지 전환 과정에서 참조가 끊어진 Docs를 수정했습니다.
  • 인가 로직의 변경으로 더이상 유의미하지 않은 클래스를 Deprecated 처리했습니다.

리뷰어를 위한 참고사항:


@maeumgagym-ci-robot-app
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Daybreak312

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@gurdl0525 gurdl0525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@maeumgagym-ci-robot-app maeumgagym-ci-robot-app bot added the lgtm Looks good to me label May 2, 2024
@maeumgagym-ci-robot-app maeumgagym-ci-robot-app bot merged commit 35491e5 into develop May 2, 2024
3 checks passed
@maeumgagym-ci-robot-app maeumgagym-ci-robot-app bot deleted the annotation branch May 2, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants