PR :: 토큰 로직 재설계 #215
Merged
PR :: 토큰 로직 재설계 #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Daybreak312 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Daybreak312 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
어떤 종류의 PR 인가요?
/kind 기능
/kind 리펙토링
이 PR이 무슨 일을 하나요? / 필요한 이유가 뭔가요?
주 변경점
이전에 JwtResolverImpl, JwtAdapter에서 처리하던 토큰의 관리 책임을 분할 및 추상화했습니다. 자세한 사항은 [com.info.maeumgagym.security.mgtoken.docs]를 참고해주세요.
요약하면, JWT의 취약점 및 관련 라이브러리의 문제점을 지적하여 새로운 토큰의 필요성을 제시했습니다.
위에서 언급된 docs를 참고해주세요.
부가 변경점
이름이 너무 추상적이기에 클래스의 책임을 제대로 표현하지 못한다 판단했습니다. 보다 구체적이도록 리네이밍했습니다.
CurrentRequestContext의 사용 위치가 CurrentRequestContextInterceptor보다 앞에서 실행될 경우 정상적으로 사용되지 않아, Filter로 전환했습니다.
CurrentRequestContextFilter의 순서(위치)의 중요성이 높아, 이전부터 존재했던 이슈였던 FilterChain과 관련된 문제점을 해결함과 동시에 Filter의 순서를 조정했습니다.
리뷰어를 위한 참고사항: