-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep Season opened but disable traffic #36
Conversation
We can merge this one as is. Next steps in dedicated tickets: |
We should absolutely avoid using any native lua call, it's not reliable and we have barely no control over behavior. We must reverse these calls instead. I suggest we keep this PR open for tracking, but instead we transform it to reversing task. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likely not an issue but the Lua code here will be executed each time player goes back to the menu (ie. disconnects), but we aim to replace it later anyways, so not an issue, just something to be aware of.
I created a dedicated ticket for replacing these calls with native hooks. #42 Do you think it's really annoying to merge this for a V0? |
I can handle the reversing part today and i'll let you do the implementation, ok for you? |
The objective of this PR was to keep the season open to maintain the radios. I close the PR. |
Related to #34 and temporary fix #25
This is just a working POC based on Kamzik123 reply.
Next steps:
OpenSeason
,CloseSeason
andGetCurrentSeasonID
methods in order to expose them to scripting APISeason
, it will not reactivate trafficI can't do better with my limited knowledge of C++ and IDA.
I'll pass the topic on to you.
cc @zpl-zak @Greavesy1899